8000 DOC: prefer colormap over color map by tacaswell · Pull Request #18576 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

DOC: prefer colormap over color map #18576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

DOC: prefer colormap over color map #18576

merged 1 commit into from
Sep 25, 2020

Conversation

tacaswell
Copy link
Member

Fix this across the entire codebase and docs.

PR Summary

In #15127 @dopplershift pointed out all of the places I used 'color map' instead of 'colormap', so via ack + sed I fixed it everywhere.

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [ x Is Flake 8 compliant (run flake8 on changed files to check).
  • [ N/A ] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswell
DOC: prefer colormap over color map
bdb82e4 
Fix this across the entire codebase and docs.
@tacaswell tacaswell added this to the v3.4.0 milestone Sep 25, 2020
jklymak
jklymak reviewed Sep 25, 2020
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change, but not sure the should change the historic what's-new etc docs?

dopplershift
dopplershift approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being annoying. 😁

Since this is a consistency of spelling change, I think it's perfectly fine to fix older things.

@jklymak jklymak merged commit 3560e84 into matplotlib:master Sep 25, 2020
@tacaswell tacaswell deleted the doc_color_map branch September 25, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tacaswell @dopplershift @jklymak
0