Remove incorrect override of pcolor/contour in parasite axes. #18560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cc5902 to
6dfc672
Compare
The override of `pcolor`, `pcolormesh`, `contour`, and `contourf` in parasite axes was actually incorrect. Perhaps things were different when that code went in, but nowadays things work just fine without any need for overriding. See e.g. the new version of demo_curvelinear_grid before and after the changes. The default gridding of `pcolor`/`pcolormesh` changed to match the one of normal Axes; I don't think this is worth going through a deprecation period...
6dfc672 to
b763649
Compare
tacaswell
approved these changes
Sep 24, 2020
|
I think if this ever worked it was due to things not resizing as it looks like we are running the aux tarnfrom and explicitly caching the results by passing the transformed input to the underlying plotting calls. This code has been like this from ~2010 but I do not think it is worth tracking down when we broke it. |
QuLogic
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override of
pcolor,pcolormesh,contour, andcontourfinparasite axes was actually incorrect. Perhaps things were different
when that code went in, but nowadays things work just fine without any
need for overriding.
See e.g. the new version of demo_curvelinear_grid before and after the
changes.
old:
new:
The default gridding of
pcolor/pcolormeshchanged to match the oneof normal Axes; I don't think this is worth going through a deprecation
period...
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).