Deprecate TextArea minimumdescent. #18528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c56f171 to
2e9f9d7
Compare
QuLogic
reviewed
Sep 22, 2020
There was a problem hiding this comment.
For reference, here is the max that @anntzer is referring to:
matplotlib/lib/matplotlib/text.py
Lines 314 to 318 in e16460f
It says it's for (the purposes of, I suppose) multiline text, but it applies to everything.
The implementation of `Text._get_layout` has effectively enforced `minimumudescent=True` (`d = max(d, lp_d)`) since ee3af29 (mpl 1.3).
2e9f9d7 to
e4f875a
Compare
timhoffm
approved these changes
Sep 22, 2020
QuLogic
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
Text._get_layouthas effectively enforcedminimumudescent=True(d = max(d, lp_d)) since ee3af29 (mpl 1.3).(See also the images in the corresponding PR, #2070.)
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).