8000 DOC: example gray level in 'Specifying Colors' tutorial by tfiers · Pull Request #18460 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

DOC: example gray level in 'Specifying Colors' tutorial #18460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2020
Merged

DOC: example gray level in 'Specifying Colors' tutorial #18460

merged 1 commit into from
Sep 12, 2020

Conversation

tfiers
Copy link
Contributor
@tfiers tfiers commented Sep 11, 2020

PR Summary

Give named example of a gray level.
This answers user question "what is light, what is dark?"

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [N/A]New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A]] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@tfiers
DOC: example gray level in 'Specifying Colors' tutorial
279dd60 
To answer user question "what is light, what is dark?"
@jklymak jklymak added this to the v3.4.0 milestone Sep 12, 2020
@jklymak
Copy link
Member
jklymak commented Sep 12, 2020

Anyone can merge on CI. Thanks @tfiers

@tfiers tfiers requested a review from jklymak September 12, 2020 00:16
@tfiers
Copy link
Contributor Author
tfiers commented Sep 12, 2020

image

woops @jklymak that was on accident

@jklymak jklymak removed their request for review September 12, 2020 00:18
@jklymak jklymak merged commit 2e82a38 into matplotlib:master Sep 12, 2020
@tfiers tfiers deleted the patch-1 branch September 12, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tfiers @jklymak
0