nbagg: Use OutputArea event to trigger figure close. #18454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting from jQuery to vanilla JavaScript, the trigger for the figure closure was set to a non-existent event name, as the 'remove' event is jQuery-specific. As there is no DOM node removal event (unless using MutationObserver), connect this handler to the notebook's `Cell` `OutputArea`'s 'cleared' event. This is triggered both by re-running a cell, and by using the Clear Output menu option. Fixes matplotlib#18447.
timhoffm
approved these changes
Sep 11, 2020
Contributor
|
|
Member
Author
|
I pushed a (hopefully safe) pin for nbconvert, so we can fix CI as well. |
Member
|
Checked this manually and it work is both brave (chrome-derivative) and firefox. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
2 tasks
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Sep 14, 2020
FIX: Use OutputArea event to trigger figure close in nbagg
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When converting from jQuery to vanilla JavaScript, the trigger for the figure closure was set to a non-existent event name, as the 'remove' event is jQuery-specific.
As there is no DOM node removal event (unless using MutationObserver), connect this handler to the notebook's
CellOutputArea's 'cleared' event. This is triggered both by re-running a cell, and by using the Clear Output menu option.Fixes #18447.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).