TkAgg bugfix: deselect buttons that are not the current _Mode #18395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Sep 2, 2020
modest redundancy on click
QuLogic
approved these changes
Sep 4, 2020
|
Thanks @richardsheridan ! |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Sep 9, 2020
… not the current _Mode Merge pull request matplotlib#18395 from richardsheridan/multi-toggle-fix FIX: deselect buttons that are not the current _Mode
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Sep 9, 2020
… not the current _Mode
QuLogic
added a commit
that referenced
this pull request
Sep 9, 2020
…-v3.3.x Backport PR #18395: TkAgg bugfix: deselect buttons that are not the current _Mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes a bug where Tk
Checkbuttonstates can become disconnected from theNavigationToolbar2Tk._Modewhen the user doesn't carefully e.g. uncheck zoom before checking pan. The core concept was copied from the QT navbar.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).