Fix Axis scale on twinned Axes. #18393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `Axes._sharex` is not set, then the subsequent `Axes.cla` will change the Axis scale to linear. If `Axes._sharex` is set, then `Axes.cla` will call `Axes.sharex` just as was done here, but without resetting scale to linear.
I changed my mind as that's a bit more work that we maybe don't want to backport, so I tweaked the test a bit to pass for now. |
tacaswell
approved these changes
Sep 9, 2020
dopplershift
approved these changes
Sep 11, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 11, 2020
dopplershift
added a commit
that referenced
this pull request
Sep 11, 2020
…393-on-v3.3.x Backport PR #18393 on branch v3.3.x (Fix Axis scale on twinned Axes.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
If
Axes._sharexis not set, then the subsequentAxes.clawill change the Axis scale to linear. IfAxes._sharexis set, thenAxes.clawill callAxes.sharexjust as was done here, but without resetting scale to linear.Fixes #18385.
This won't pass yet, as it turns out that twinned Axes double-draw the frame, though if we really need to apply this quickly, I can increase the tolerance.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).