10000 Clarification in ArtistAnimation docstring by dstansby · Pull Request #18384 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Clarification in ArtistAnimation docstring #18384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2020
Merged

Clarification in ArtistAnimation docstring #18384

merged 2 commits into from
Sep 1, 2020

Conversation

dstansby
Copy link
Member

xref #18381 - should make the docstring a little bit clearer.

@dstansby dstansby mentioned this pull request Aug 31, 2020
Closed
QuLogic
QuLogic previously requested changes Aug 31, 2020
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs don't build.

dopplershift
dopplershift approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor
@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the @QuLogic 's fix

@tacaswell @QuLogic
DOC: fix markup
0591589 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
tacaswell
tacaswell approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on green.

@tacaswell tacaswell dismissed QuLogic’s stale review August 31, 2020 22:08

Committed @QuLogic 's suggested diff

@tacaswell tacaswell added this to the v3.4.0 milestone Aug 31, 2020
@dstansby dstansby merged commit f7ae157 into matplotlib:master Sep 1, 2020
@dstansby dstansby deleted the artan-doc branch September 1, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dopplershift dopplershift dopplershift approved these changes

@QuLogic QuLogic QuLogic left review comments

Assignees
No one assigned
Labels
Documentation topic: animation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @tacaswell @dopplershift @QuLogic
0