8000 Cleanup tkinter state between tests by richardsheridan · Pull Request #18265 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup tkinter state between tests #18265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Cleanup tkinter state between tests #18265

wants to merge 1 commit into from

Conversation

richardsheridan
Copy link
Contributor

PR Summary

This PR is a second attempt to fix #18246. Perhaps if we are careful to reset tkinter between tests, things will be less flaky. There is a lot of logic in the cpython test suite dedicated to this.

As with #18261, draft PR to engage CI.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

8331
@richardsheridan richardsheridan deleted the backend_tk_tests_cleanup branch August 15, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_never_update is flaky
1 participant
@richardsheridan
0