8000 Fix Axes3D.add_collection3d issues by thangleiter · Pull Request #17851 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix Axes3D.add_collection3d issues #17851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 10, 2020
Merged

Fix Axes3D.add_collection3d issues #17851

merged 5 commits into from
Aug 10, 2020

Conversation

thangleiter
Copy link
Contributor
@thangleiter thangleiter commented Jul 7, 2020 •
edited
Loading

PR Summary

This PR fixes the following bugs in Axes3D.add_collection3d (#17755):

  • Axes3D.add_collection3d cannot deal with line segments instead of points for the zs parameter.
  • Axes3D.add_collection3d does not return the Line3DCollection object, thus one cannot for example add a colorbar.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.4.0 milestone Jul 7, 2020
QuLogic
QuLogic reviewed Jul 11, 2020
View reviewed changes
thangleiter and others added 2 commits August 8, 2020 18:52
@thangleiter @QuLogic
Use more readable np.column_stack
5b00412 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@thangleiter
Check if zs has same length as paths, raise else
f24663f
@QuLogic QuLogic merged commit 647a966 into matplotlib:master Aug 10, 2020
@QuLogic
Copy link
Member
QuLogic commented Aug 10, 2020

Thanks @thangleiter! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@dopplershift dopplershift mentioned this pull request Aug 11, 2020
Closed
@thangleiter thangleiter deleted the fix_add_collection3d_issues branch August 11, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thangleiter @QuLogic @dopplershift @tacaswell
111
0