Move "Request a new feature" from How-to to Contributing #17842
Conversation
86bac5b to
6e393fb
Compare
doc/devel/contributing.rst
Outdated
| The Matplotlib developers will give feedback on the feature proposal. After | ||
| acceptance, the feature can be implemented. Since Matplotlib is an open source |
There was a problem hiding this comment.
what does acceptance mean? this may be a longer discussion for the call, but should be pinned down.
There was a problem hiding this comment.
I want to express that not every feature request may be deemed an appropriate extension of Matplotlib by core developers. We welcome if somebody proposes a feature and also implements it, but it may be good to first get feedback before you start implementing.
I don't want to go into possible details of the feedback/approval/acceptance process here.
Thinking again, I think we can leave the sentence out.
There was a problem hiding this comment.
"If there is significant support, you can try implementing the feature"?
There was a problem hiding this comment.
Thanks for the proposal. I have the impression that it might fee a little intimidating. "significant" is a strong word and may be a barrier for people considering a propsal. Also, the phrasing might give the false impression that the proposer must also implement it.
I'm going with removing the sentence. I think it's clear enough; and it's also not the end of the world if a PR is opened before a feature is fully discussed. Sometimes you may even need it to illustrate the intention.
6e393fb to
5b213a5
Compare
PR Summary
Part of moving all contribution related info from How-to to the developers guide. (Related/follow up to #17837 and #17825.)
I've removed mentioning the mailing list:
I suppose this is just outdated. One could add it as an alternative to the issue tracker, but OTOH the issue tracker makes management of feature requests much simpler, and personally, I would not want to have feature requests coming via the malinglist.Not mentioning the mailinglist here was discussed and approved in the last dev call.