Fix tk tooltips for dark themes. #17756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not setting the background explicitly to a light color is sufficient to avoid having white text on a light color when using a dark desktop theme. (The forced background color goes back to when ToolTip was introduced, in c887139, with no comment as to why.)
timhoffm
approved these changes
Jun 25, 2020
|
Putting this on 3.3 though it's not critical because it goes along with a lot of the other dark theme fixes we did for it. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 25, 2020
QuLogic
added a commit
that referenced
this pull request
Jun 26, 2020
…756-on-v3.3.x Backport PR #17756 on branch v3.3.x (Fix tk tooltips for dark themes.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not setting the background explicitly to a light color is sufficient to
avoid having white text on a light color when using a dark desktop
theme.
(The forced background color goes back to when ToolTip was introduced,
in c887139, with no comment as to why.)
PR Summary
PR Checklist