8000 Rewrite pdf test to use check_figures_equal. by anntzer · Pull Request #17617 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Rewrite pdf test to use check_figures_equal. #17617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

Rewrite pdf test to use check_figures_equal. #17617

merged 1 commit into from
Jun 17, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 11, 2020

... instead of manually calling compare_images().
(This now tests that both the pdf and the eps results are blank (and
thus equal), rather than checking that the two of them are equal.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Rewrite pdf test to use check_figures_equal.
6939c21 
... instead of manually calling compare_images().
(This now tests that both the pdf and the eps results are blank (and
thus equal), rather than checking that the two of them are equal.)
@timhoffm timhoffm added this to the v3.3.0 milestone Jun 17, 2020
@timhoffm timhoffm merged commit 45d3877 into matplotlib:master Jun 17, 2020
@anntzer anntzer deleted the figeq branch June 17, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: pdf topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0