Fix LightSource.shade on fully unmasked array. #17481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous versions of NumPy, `np.clip` would expand the mask, but it no longer does so. Use `np.ma.is_masked` to check for a mask instead of `hasattr`, as the former also checks whether any *values* are actually masked. Fixes matplotlib#17455.
tacaswell
approved these changes
May 21, 2020
dstansby
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In previous versions of NumPy,
np.clipwould expand the mask, but it no longer does so. Usenp.ma.is_maskedto check for a mask instead ofhasattr, as the former also checks whether any values are actually masked.Fixes #17455.
PR Checklist