8000 Keep validate_date private. by anntzer · Pull Request #17414 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Keep validate_date private. #17414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2020
Merged

Keep validate_date private. #17414

merged 1 commit into from
May 14, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 14, 2020

I'm slowly turning all validator functions to be private, so let's start
right away with this one (which is not in any released version yet).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer 8000
Keep validate_date private.
3756e58 
I'm slowly turning all validator functions to be private, so let's start
right away with this one (which is not in any released version yet).
@anntzer anntzer added this to the v3.3.0 milestone May 14, 2020
@QuLogic QuLogic merged commit 7ce2788 into matplotlib:master May 14, 2020
@anntzer anntzer deleted the validate_date branch May 15, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
topic: rcparams
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @story645
0