8000 Fixes icon clipping issue with WxAgg NavigationToolbar2 for wxpython 4.1.0 by jbhopkins · Pull Request #17328 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fixes icon clipping issue with WxAgg NavigationToolbar2 for wxpython 4.1.0 #17328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2020
Merged

Fixes icon clipping issue with WxAgg NavigationToolbar2 for wxpython 4.1.0 #17328

merged 1 commit into from
May 16, 2020

Conversation

jbhopkins
Copy link
Contributor

PR Summary

This fixes the problem of icons clipping in the NavigationToolbar2 using the WxAgg backend for wxpython 4.1.0 documented in issue #17326 . At the moment that issue seems to be only happening on MacOS, so this is mac specific. However, I have been unable to test 4.1.0 on linux, so it may also need to be applied there.

This fix has no effect on the ToolBar appearance in wxpython 4.0.4, so it should be backwards compatible in that way.

Toolbar in 4.1.0 without fix:
mpl_toolbar_wx4p10

Toolbar in 4.1.0 with fix
mpl_toolbar_wx4p1_fix

Toolbar in 4.0.4 without fix:
mac_mpl_toolbar_old

Toolbar in 4.0.4 with fix:
mpl_toolbar_4p0p4_toolbar_icon_fix

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Copy link
Member
QuLogic commented May 5, 2020

This does not seem to cause any deleterious effect on wxPython 4.1 in Linux using their Ubuntu wheels. But the original bug never occurred there either.

@QuLogic QuLogic added this to the v3.3.0 milestone May 5, 2020
@efiring
Copy link
Member
efiring commented May 7, 2020

This looks plausible and harmless. We are probably short of additional people who can test it, especially since I don't see wx 4.1.0 on conda-forge.

timhoffm
timhoffm approved these changes May 16, 2020
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable.

I approve even though I cannot test it and I do not fully understand https://docs.wxpython.org/wx.ToolBar.html#wx.ToolBar.GetToolBitmapSize.

I don‘t think we have somebody who can easily test this. Let‘s not put too much effort in. The change is limited to wxmac and AFAICS the worst that could happen would be that the toolbar has a wrong size and/or its buttons are rendered badly. But I trust the OP that it works based on the screenshots.

@efiring efiring merged commit 7a2a049 into matplotlib:master May 16, 2020
@jbhopkins jbhopkins deleted the wx_4p10 branch August 7, 2020 20:23
@QuLogic QuLogic mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbhopkins @QuLogic @efiring @timhoffm
0