8000 Fix polar tests. by anntzer · Pull Request #17195 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix polar tests. #17195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2020
Merged

Fix polar tests. #17195

merged 1 commit into from
Apr 19, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 19, 2020

The numpy import went away, breaking the tests. Also move them out of
test_subplots.py given that they have nothing to do with subplots; we
could move them to test_axes.py but a new test_polar.py seems better (we
could also later move polar tests from test_axes to test_polar). Also
some test refactoring and fix an error message.

Fix following #16717.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

8000
@anntzer
Fix polar tests.
ba4d740 
The `numpy` import went away, breaking the tests.  Also move them out of
test_subplots.py given that they have nothing to do with subplots; we
could move them to test_axes.py but a new test_polar.py seems better (we
could also later move polar tests from test_axes to test_polar).  Also
some test refactoring and fix an error message.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing topic: polar labels Apr 19, 2020
@anntzer anntzer added this to the v3.3.0 milestone Apr 19, 2020
timhoffm
timhoffm approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on CI.

@jklymak jklymak merged commit ee2d046 into matplotlib:master Apr 19, 2020
@anntzer anntzer deleted the polartests branch April 19, 2020 18:55
@anntzer anntzer mentioned this pull request Apr 19, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @jklymak
0