Fix Figure.add_axes(rect=...). #17164

QuLogic · 2020-04-17T03:07:59Z

PR Summary

This makes it behave as if the signature was actually add_axes(rect, **kwargs) instead of *args.

Has Pytest style unit tests
Code is Flake 8 compliant
[N/A] New features are documented, with examples if plot related
[N/A] Documentation is sphinx and numpydoc compliant
[N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
[N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

brunobeltran · 2020-04-17T03:13:17Z

LGTM

This makes it behave as if the signature was actually `add_axes(rect, **kwargs)` instead of `*args`.

QuLogic added this to the v3.3.0 milestone Apr 17, 2020

Fix Figure.add_axes(rect=...).

085554e

This makes it behave as if the signature was actually `add_axes(rect, **kwargs)` instead of `*args`.

QuLogic force-pushed the add_axes-rect branch from fb0d63e to 085554e Compare April 17, 2020 05:35

efiring approved these changes Apr 17, 2020

View reviewed changes

efiring merged commit 5eea274 into matplotlib:master Apr 17, 2020

QuLogic deleted the add_axes-rect branch April 17, 2020 20:32