8000 Cleanup/Simplify Cell._set_text_position. by anntzer · Pull Request #17123 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content
8000

Cleanup/Simplify Cell._set_text_position. #17123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2020
Merged

Cleanup/Simplify Cell._set_text_position. #17123

merged 1 commit into from
Apr 14, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 13, 2020

Directly pass loc to the text horizontalalignment in the
constructor, which will avoid handling anything-but-"center"-and-"left"
as "right", but error out (from the constructor, rather than at draw
time) instead. Also, this means that changing the text alignment from
set_text_props will work "as expected".

Make the docstring style-compliant.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Apr 13, 2020
@anntzer anntzer force-pushed the table_set_text_position branch from 937f331 to 9f99995 Compare April 13, 2020 20:11
@anntzer
Cleanup/Simplify Cell._set_text_position.
6ff1f82 
Directly pass *loc* to the text `horizontalalignment` in the
constructor, which will avoid handling anything-but-"center"-and-"left"
as "right", but error out (from the constructor, rather than at draw
time) instead.  Also, this means that changing the text alignment from
`set_text_props` will work "as expected".

Make the docstring style-compliant.
@anntzer anntzer force-pushed the table_set_text_position branch from 9f99995 to 6ff1f82 Compare April 13, 2020 21:22
@QuLogic QuLogic merged commit 8c390c0 into matplotlib:master Apr 14, 2020
@anntzer anntzer deleted the table_set_text_position branch April 14, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
API: argument checking
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic
0