8000 TextBox improvements. by anntzer · Pull Request #17117 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

TextBox improvements. #17117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

TextBox improvements. #17117

merged 1 commit into from
Apr 15, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 13, 2020

Cleanup textbox example: 1) handling the initial text through the normal
submit callback seems simpler; 2) use "normal" autoscaling methods,
which correctly apply margins and would also work if other artists were
involved. This revealed that TextBox.set_val throws an exception due
to no cached renderer if the figure has never been rendered before.
Given that TextBox is going to trigger a bunch of redraws anyways for
user edits, we may as well trigger a first draw if needed to cache a
renderer first.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
TextBox improvements.
b833a2b 
Cleanup textbox example: 1) handling the initial text through the normal
`submit` callback seems simpler; 2) use "normal" autoscaling methods,
which correctly apply margins and would also work if other artists were
involved.  This revealed that `TextBox.set_val` throws an exception due
to no cached renderer if the figure has never been rendered before.
Given that TextBox is going to trigger a bunch of redraws anyways for
user edits, we may as well trigger a first draw if needed to cache a
renderer first.
@anntzer anntzer added this to the v3.3.0 milestone Apr 13, 2020
@timhoffm timhoffm merged commit b306a8e into matplotlib:master Apr 15, 2020
@anntzer anntzer deleted the textbox branch April 15, 2020 08:04
@QuLogic QuLogic mentioned this pull request Jul 20, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0