Cleanups to Qt backend. #17070
Merged
Cleanups to Qt backend. #17070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Apr 8, 2020
| QtWidgets.QToolBar.__init__(self, parent) | ||
| NavigationToolbar2.__init__(self, canvas) | ||
|
|
||
| @cbook.deprecated("3.3", alternative="self.canvas.parent()") | ||
| @property | ||
| def parent(self): | ||
| return self._parent | ||
| return self.canvas.parent() |
There was a problem hiding this comment.
I'm not sure this is correct, is it actually guaranteed that the toolbar and the canvas share the same Qt parent?
tacaswell
approved these changes
Apr 8, 2020
- Move Qt4/Qt5-dependent logic re: devicePixelRatio to qt_compat; these functions are documented to have existed ever since Qt5 was released. - In Toolbar, no need to set `.canvas` (the base class init does it) or `._parent` (one can just return the canvas' `.parent()`); `.basedir` is just a small helper which doesn't exist in other backends and doesn't warrant being public.
|
I reverted that specific change -- I have some further plans for cleanup, but that specific point doesn't matter. |
timhoffm
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these functions are documented to have existed ever since Qt5 was
released.
.canvas(the base class init does it)or
._parent(one can just return the canvas'.parent());.basediris just a small helper which doesn't exist in otherbackends and doesn't warrant being public.
PR Summary
PR Checklist