8000 Made INSTALL.rst consistent by SidharthBansal · Pull Request #16998 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Made INSTALL.rst consistent #16998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

Made INSTALL.rst consistent #16998

merged 1 commit into from
Apr 1, 2020

Conversation

SidharthBansal
Copy link
Contributor
@SidharthBansal SidharthBansal commented Apr 1, 2020 •
edited
Loading

PR Summary

Changed ;->. to make them consistent across the document
Changed heading to Installtion Guide

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@SidharthBansal
Made INSTALL.rst consistent
5c25b0a 
### PR Summary

Changed `;`->`.` to make them consistent across the document
Changed heading to `Installtion Guide`
@SidharthBansal
Copy link
Contributor Author

Hi, I am Sidharth Bansal, new to this organisation. I have made a small change. @anntzer @story645
Kindly review the changes and suggest me if any changes required.

I have submitted the GSoC proposal. I am looking forward to contribute to Matplotlib this April so that I can grasp insights of the repo and tech stack. This will help me to go deep into the use cases for the proposal.

Thanks

@tacaswell tacaswell added this to the v3.2.2 milestone Apr 1, 2020
@tacaswell
Copy link
Member

Looks good to me, thank you!

@timhoffm timhoffm merged commit 98ef7a6 into matplotlib:master Apr 1, 2020
@timhoffm
Copy link
Member
timhoffm commented Apr 1, 2020

Thanks!

@lumberbot-app
Copy link
lumberbot-app bot commented Apr 1, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 98ef7a6f71e9495947f50e8dc5551ba1d16f95e7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16998: Made INSTALL.rst consistent'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16998-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16998 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@tacaswell
Copy link
Member

We have changed minimum versions between master and v3.2.x. I think it is OK to not backport these changes.

@tacaswell tacaswell modified the milestones: v3.2.2, v3.3.0 Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SidharthBansal @tacaswell @timhoffm
0