8000 Alpha kwarg fix by tacaswell · Pull Request #1695 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Alpha kwarg fix #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2013
Merged

Alpha kwarg fix #1695

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17fa943
Fixed code added in 0c20b5c8013f93147c221f7c035f465c7825d10b
tacaswell Jan 23, 2013
edc48f0
updated the way the line color + alpha is handled to match how it is
tacaswell Jan 23, 2013
842a164
Updated the alpha/translucent test to also test lines and a mix of
tacaswell Jan 23, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed code added in 0c20b5c 
(PR #1505).

Tests added is #1663 pass with this patch.
  • Loading branch information
@tacaswell
tacaswell committed Jan 23, 2013
commit 17fa943221f9ec81064b2937101651242b0c5cc3
8 changes: 4 additions & 4 deletions lib/matplotlib/lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def contains(self, mouseevent):
# the math involved in checking for containment (here and inside of segment_hits) assumes
# that it is OK to overflow. In case the application has set the error flags such that
# an exception is raised on overflow, we temporarily set the appropriate error flags here
# and set them back when we are finished.
# and set them back when we are finished.
olderrflags = np.seterr(all='ignore')
try:
# Check for collision
Expand Down Expand Up @@ -448,7 +448,7 @@ def recache(self, always=False):
def _transform_path(self, subslice=None):
"""
Puts a TransformedPath instance at self._transformed_path,
all invalidation of the transform is then handled by the
all invalidation of the transform is then handled by the
TransformedPath instance.
"""
# Masked arrays are now handled by the Path class itself
Expand Down Expand Up @@ -540,7 +540,7 @@ def draw(self, renderer):
else:
gc.set_foreground(edgecolor)
gc.set_linewidth(self._markeredgewidth)
gc.set_alpha(self._alpha)

marker = self._marker
tpath, affine = transformed_path.get_transformed_points_and_affine()
if len(tpath.vertices):
Expand Down Expand Up @@ -970,7 +970,7 @@ def _get_rgba_face(self, alt=False):
if is_string_like(facecolor) and facecolor.lower() == 'none':
rgbaFace = None
else:
rgbaFace = colorConverter.to_rgba(facecolor)
rgbaFace = colorConverter.to_rgba(facecolor, self._alpha)
return rgbaFace

# some aliases....
Expand Down
0