8000 Add tests for toolmanager. by anntzer · Pull Request #16933 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Add tests for toolmanager. #16933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

Add tests for toolmanager. #16933

merged 1 commit into from
Apr 15, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 27, 2020 •
edited
Loading

... and fix Help tool for tk (it needs a gif icon, generated (like the
other gifs) with convert -antialias -geometry 24x24 help.svg help.gif)
(#6610).

... and also edit the matplotlibrc template to mention its availability.

Edit: plenty of new coverage: https://codecov.io/gh/matplotlib/matplotlib/compare/d9b722f8a6ee91955f83609b52b2d2b203316385...11346704f6e42f85b2a19cccc6f3be6b81451bb9/tree/lib/matplotlib

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

8000
@anntzer anntzer added this to the v3.3.0 milestone Mar 27, 2020
@anntzer anntzer force-pushed the toolmanager branch 2 times, most recently from 5448b1f to 1134670 Compare March 27, 2020 17:39
@anntzer anntzer mentioned this pull request Mar 29, 2020
Merged
6 tasks
timhoffm
timhoffm approved these changes Mar 29, 2020
View reviewed changes
@tacaswell
Copy link
Member

Restarted the failing CI job (sub-process timeouts on mac on travis). Anyone can merge on green.

@timhoffm
Copy link
Member

Subprocess still times out.

@anntzer
Copy link
Contributor Author
anntzer commented Mar 30, 2020

I wouldn't be surprised if that really failed, but that'll need someone on a Mac to test locally...

@anntzer
Add tests for toolmanager.
f2bd383 
... and fix Help tool for tk (it needs a gif icon, generated (like the
other gifs) with `convert -antialias -geometry 24x24 help.svg help.gif`).

... and also edit the matplotlibrc template to mention its availability.
@anntzer
Copy link
Contributor Author
anntzer commented Apr 15, 2020

Actually toolmanager is clearly not implemented for macosx, so let's just skip it.

@QuLogic QuLogic merged commit a96b83d into matplotlib:master Apr 15, 2020
@anntzer anntzer deleted the toolmanager branch April 15, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @QuLogic
0