8000 Docs: Change Python 2 note to past tense by hugovk · Pull Request #16651 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Docs: Change Python 2 note to past tense #16651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

Docs: Change Python 2 note to past tense #16651

merged 1 commit into from
Mar 3, 2020

Conversation

hugovk
Copy link
Contributor
@hugovk hugovk commented Mar 3, 2020 •
edited
Loading

PR Summary

PR Checklist

  • [n/a] Has Pytest style unit tests
  • [n/a] Code is Flake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

I noticed the announcement on https://matplotlib.org/ is written for when 2020-01-01 is in the future:

image

The announcement for the LTS releases on https://matplotlib.org/2.2.5/index.html is:

image

This PR combines the texts, in the past tense.

@tacaswell tacaswell added this to the 3.2-doc milestone Mar 3, 2020
timhoffm
timhoffm approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Eventually this notification box will disappear (see #16253). But it‘s good to be updated till then.

@tacaswell tacaswell merged commit cfd5463 into matplotlib:master Mar 3, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 3, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#16651: Docs: Change Python 2 note to past tense
ac8344b
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 3, 2020
Merged
@hugovk hugovk deleted the patch-2 branch March 3, 2020 21:38
QuLogic added a commit that referenced this pull request Mar 4, 2020
@QuLogic
Merge pull request #16654 from meeseeksmachine/auto-backport-of-pr-16…
ea62ccd 
…651-on-v3.2.0-doc

Backport PR #16651 on branch v3.2.0-doc (Docs: Change Python 2 note to past tense)
@QuLogic
Copy link
Member
QuLogic commented Mar 4, 2020

This milestone should backport to v3.2.x too, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2-doc
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @QuLogic @tacaswell @timhoffm
0