8000 Update annotation tutorial. by anntzer · Pull Request #16647 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Update annotation tutorial. #16647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Update annotation tutorial. #16647

merged 1 commit into from
Mar 4, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 3, 2020

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 3, 2020
timhoffm
timhoffm reviewed Mar 3, 2020
View reviewed changes
tutorials/text/annotations.py
annotated point but from some other point.
:class:`~matplotlib.text.OffsetFrom` is a helper class for such cases.
5. Sometimes, you want your annotation with some "offset points", not from the
annotated point but from some other point. `.text.OffsetFrom` is a helper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
annotated point but from some other point. `.text.OffsetFrom` is a helper
annotated point but from some other point. `~.text.OffsetFrom` is a helper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this specific class is obscure enough that I intentionally decided to mention the parent module, even though this may appear slightly inconsistent. I can remove it if you feel strongly about it, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@timhoffm timhoffm merged commit 25b80c3 into matplotlib:master Mar 4, 2020
@anntzer anntzer deleted the anntut branch March 4, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @timhoffm
0