10BC0 Deprecate validate_webagg_address. by anntzer · Pull Request #16644 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate validate_webagg_address. #16644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuLogic merged 1 commit into from
Mar 11, 2020
Merged

Deprecate validate_webagg_address. #16644

QuLogic merged 1 commit into from
Mar 11, 2020

Conversation

@anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 3, 2020

It is overly strict: it only accepts IPv4 addresses, even though e.g.
"localhost" works just fine, as can be checked with e.g.

$ MPLBACKEND=webagg python -c 'from pylab import *; dict.__setitem__(rcParams, "webagg.address", "localhost"); plot(); show()'

(really, just an excuse to further trim down rcsetup...)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 3, 2020
@anntzer
Deprecate validate_webagg_address.
d69d480 
It is overly strict: it only accepts IPv4 addresses, even though e.g.
"localhost" works just fine, as can be checked with e.g.
```
$ MPLBACKEND=webagg python -c 'from pylab import *; dict.__setitem__(rcParams, "webagg.address", "localhost"); plot(); show()'
```
(really, just an excuse to further trim down rcsetup...)
@anntzer
Copy link
Contributor Author
anntzer commented Mar 10, 2020

rebased

@QuLogic QuLogic merged commit d492a65 into matplotlib:master Mar 11, 2020
@anntzer anntzer deleted the webagg_address branch March 11, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

GUI: webagg topic: rcparams

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @QuLogic @timhoffm
0