8000 Cleanup quiver3d examples. by anntzer · Pull Request #16614 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup quiver3d examples. #16614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2020
Merged

Cleanup quiver3d examples. #16614

merged 1 commit into from
Mar 1, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 1, 2020
  • Merge pivot="tip"/"middle"/"tail" into a single test.
  • Turn empty test into an check_figures_equal, and use a less obfuscated
    way to define six empty lists.
  • Make the definition of w fit in one line.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Cleanup quiver3d examples.
ced2f7f 
- Merge pivot="tip"/"middle"/"tail" into a single test.
- Turn empty test into an check_figures_equal, and use a less obfuscated
  way to define six empty lists.
- Make the definition of `w` fit in one line.
@anntzer anntzer added this to the v3.3.0 milestone Mar 1, 2020
@dstansby dstansby merged commit 0cbbf1f into matplotlib:master Mar 1, 2020
@anntzer anntzer deleted the q3d branch March 1, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: mplot3d topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @dstansby
0