Added graphviz_docs to conf.py #16610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
approved these changes
Mar 1, 2020
|
It's mentioned in the graphviz extension but passing it in as an arg didn't work for me: |
dstansby
approved these changes
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Was having trouble getting my docs to build, build kept reporting it couldn't find
graphviz_dotenvironment variable and only thing that seemed to fix it was setting thegraphviz_dotvariable in conf.py. (longer description on discourse)Used
shutil.where('dot')since that's used earlier in the file to check if graphviz is installed so it should be portable/universal. Can do something like this instead though if folks think it's a better idea: