E528 Deprecate more rc validators. by anntzer · Pull Request #16604 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate more rc validators. #16604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuLogic merged 1 commit into from
Mar 10, 2020
Merged

Deprecate more rc validators. #16604

QuLogic merged 1 commit into from
Mar 10, 2020

Conversation

@anntzer
Copy link
Contributor
@anntzer anntzer commented Feb 28, 2020
  • validate_bool_maybe_none is now unused; if we really need it back
    we'd make it private and I'd anyways rather add machinery so that
    one can just specify it as [bool, None] (or Optional[bool]) in
    _prop_validators.
  • validate_hinting will become a plain list after the deprecation
    period.
  • validate_movie_writer makes it impossible to set movie.writer to
    a third-party animation writer, because that third-party module
    will necessarily first import matplotlib before being able to
    register its writer, and thus the matplotlibrc file will be parsed
    before the writer is registered. In any case,
    MovieWriterRegistry.__getitem__ also raises an informative error
    on unknown writer names, which should be enough, so let's just
    accept any string.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Feb 28, 2020
@anntzer
Deprecate more rc validators.
37c7620 
- validate_bool_maybe_none is now unused; if we really need it back
  we'd make it private and I'd anyways rather add machinery so that
  one can just specify it as `[bool, None]` (or `Optional[bool]`) in
  _prop_validators.
- validate_hinting will become a plain list after the deprecation
  period.
- validate_movie_writer makes it impossible to set movie.writer to
  a third-party animation writer, because that third-party module
  will necessarily first import matplotlib before being able to
  register its writer, and thus the matplotlibrc file will be parsed
  before the writer is registered.  In any case,
  `MovieWriterRegistry.__getitem__` also raises an informative error
  on unknown writer names, which should be enough, so let's just
  accept any string.
@QuLogic QuLogic merged commit 001dd9b into matplotlib:master Mar 10, 2020
@anntzer anntzer deleted the rcv branch March 10, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Maintenance topic: rcparams

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @QuLogic @timhoffm
0