Deprecate dviread.Encoding. #16596
Merged
Deprecate dviread.Encoding. #16596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Mar 11, 2020
timhoffm
approved these changes
Mar 11, 2020
In 2c0f5ec I found that dviread.Encoding was mostly broken (it didn't correctly split entries in the encoding file and instead returned everything concatenated as a single string) and introduced _parse_enc to make usetex loading work in SVG. I didn't deprecate Encoding yet because it appeared to work for the pdf backend. As it turns out it "works" because the format needed by the pdf backend is exactly the same as the one in enc files, so it doesn't mind the failure to split the string. Still, using a proper parser (_parse_enc) seems better... So deprecate the broken Encoding.
|
will selfmerge on ci success per #16231 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In 2c0f5ec I found that dviread.Encoding was mostly broken (it didn't
correctly split entries in the encoding file and instead returned
everything concatenated as a single string) and introduced _parse_enc to
make usetex loading work in SVG. I didn't deprecate Encoding yet
because it appeared to work for the pdf backend.
As it turns out it "works" because the format needed by the pdf backend
is exactly the same as the one in enc files, so it doesn't mind the
failure to split the string. Still, using a proper parser (_parse_enc)
seems better... So deprecate the broken Encoding.
second commit is a minor style fix at the same place, and a small microoptimization of _parse_enc which is both slightly faster and shorter.
PR Checklist