10000 Reword intro to colors api docs. by anntzer · Pull Request #16435 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Reword intro to colors api docs. #16435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

Reword intro to colors api docs. #16435

merged 1 commit into from
Feb 7, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Feb 7, 2020

The previous wording was a bit awkward (both "examples" and "tutorials"
demonstrate controlling colors... and do more than showing the
colormaps).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Reword intro to colors api docs.
6e8155f 
The previous wording was a bit awkward (both "examples" and "tutorials"
demonstrate controlling colors... and do more than showing the
colormaps).
@anntzer anntzer added this to the v3.3.0 milestone Feb 7, 2020
@codecov
Copy link
codecov bot commented Feb 7, 2020

Codecov Report

Merging #16435 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16435      +/-   ##
==========================================
- Coverage   80.87%   80.79%   -0.08%     
==========================================
  Files         306      306              
  Lines       75758    75758              
  Branches     9690     9690              
==========================================
- Hits        61268    61212      -56     
- Misses      11953    12004      +51     
- Partials     2537     2542       +5
Impacted Files Coverage Δ
lib/matplotlib/backends/backend_macosx.py 4.39% <0.00%> (-36.27%) ⬇️
lib/matplotlib/backends/qt_compat.py 48.42% <0.00%> (-3.16%) ⬇️
lib/matplotlib/backends/backend_qt5.py 56.21% <0.00%> (-1.17%) ⬇️
lib/matplotlib/backends/backend_wx.py 49.11% <0.00%> (-0.84%) ⬇️
lib/matplotlib/font_manager.py 74.53% <0.00%> (-0.75%) ⬇️
lib/matplotlib/cbook/__init__.py 76.76% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c449ee4...6e8155f. Read the comment docs.

@tacaswell tacaswell modified the milestones: v3.3.0, v3.2.0 Feb 7, 2020
@tacaswell tacaswell merged commit b66fecd into matplotlib:master Feb 7, 2020
@anntzer anntzer deleted the colorapi branch February 7, 2020 15:49
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 7, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#16435: Reword intro to colors api docs.
cb34119
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 7, 2020
Merged
tacaswell added a commit that referenced this pull request Feb 7, 2020
@tacaswell
Merge pull request #16436 from meeseeksmachine/auto-backport-of-pr-16…
8aa4e46 
…435-on-v3.2.x

Backport PR #16435 on branch v3.2.x (Reword intro to colors api docs.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @story645 @tacaswell
0