8000 "gif" third-party package added to the extension page by maxhumber · Pull Request #16380 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

"gif" third-party package added to the extension page #16380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2020
Merged

"gif" third-party package added to the extension page #16380

merged 2 commits into from
Jan 31, 2020

Conversation

maxhumber
Copy link
Contributor

PR Summary

Added the gif package to the third-party package page at the behest of this tweet!

PR Checklist

  • [N/A] Has Pytest style unit tests
  • [N/A] Code is Flake 8 compliant
  • [✅] New features are documented, with examples if plot related
  • [✅] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Note

Hope I did this right. Thanks for the invitation! Let me know how I can improve this PR if need be!

@ImportanceOfBeingErnest
Copy link
Member

Thanks for this PR. Can I suggest to put gif and animatplot into a new section named animations or similar - because those are not really about interactivity?

@maxhumber
Copy link
Contributor Author

@ImportanceOfBeingErnest just moved all three animation libraries into their own section (sorted alphabetically)!

ImportanceOfBeingErnest
ImportanceOfBeingErnest approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member
@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displa 8000 yed to describe this comment to others. Learn more.

This looks good to me.
Unfortunately, no circleci test have been run on this (possibly there was a maintainance(?)), so I will not directly merge.

@maxhumber
Copy link
Contributor Author

This looks good to me.
Unfortunately, no circleci test have been run on this (possibly there was a maintainance(?)), so I will not directly merge.

Okay! Is there anything more that you need me to do?

@ImportanceOfBeingErnest
Copy link
Member

Okay! Is there anything more that you need me to do?

No. Thanks again for your PR.

@jklymak jklymak closed this Jan 31, 2020
@jklymak jklymak reopened this Jan 31, 2020
@jklymak
Copy link
Member
jklymak commented Jan 31, 2020

Recycled to re-run CI

@codecov
Copy link
codecov bot commented Jan 31, 2020

Codecov Report

Merging #16380 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16380   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files         307      307           
  Lines       75745    75745           
  Branches     9690     9690           
=======================================
  Hits        61245    61245           
  Misses      11961    11961           
  Partials     2539     2539
Impacted Files Coverage Δ
lib/matplotlib/cbook/__init__.py 76.87% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4dbf4e...948ed92. Read the comment docs.

@jklymak
Copy link
Member
jklymak commented Jan 31, 2020

LGTM https://30024-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/thirdpartypackages/index.html#gif

CI passed before, so merging....

@jklymak jklymak merged commit 786ed93 into matplotlib:master Jan 31, 2020
@jklymak jklymak added this to the v3.3.0 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maxhumber @ImportanceOfBeingErnest @jklymak
0