8000 TST: test_acorr (replaced image comparison with figure comparison) by pharshalp · Pull Request #16365 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

TST: test_acorr (replaced image comparison with figure comparison) #16365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2020
Merged

TST: test_acorr (replaced image comparison with figure comparison) #16365

merged 1 commit into from
Feb 8, 2020

Conversation

pharshalp
Copy link
Contributor
@pharshalp pharshalp commented Jan 29, 2020 •
edited
Loading

PR Summary

attempting to address the first bullet from #15054 🤞

~~Old image for acorr
https://user-images.githubusercontent.com/15175620/73325631-3a6e1880-421d-11ea-9d22-c4939741edd5.png
New image for acorr
https://user-images.githubusercontent.com/15175620/73325639-435eea00-421d-11ea-9542-605faf629ca7.png

Old image for image_interps
https://user-images.githubusercontent.com/15175620/73325664-58d41400-421d-11ea-9c27-4408662f7519.png

New image for image_interps
https://user-images.githubusercontent.com/15175620/73325673-5f628b80-421d-11ea-8f8d-347783f169a0.png

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@pharshalp pharshalp changed the title Removed text from test images TST: Removed text from test images Jan 29, 2020
@pharshalp
Copy link
Contributor Author
pharshalp commented Jan 29, 2020 •
edited
Loading

realized that svg wasn't generated automatically... will update it soon. realized that the svg file I generated manually is incorrect. Need to figure out why pytest isn't automatically generating the svg file (it did generate pdfs and pngs).

@anntzer
Copy link
Contributor
anntzer commented Jan 29, 2020 •
edited
Loading

As per #16363 (comment) I think the second image should be left as is, sorry again. The first one could be turned into a @check_figures_equal between calling ax.acorr and manually calling np.correlate and generating the corresponding plot using ax.vlines/ax.hline (which is what ax.acorr uses internally).

@pharshalp
Copy link
Contributor Author

As per #16363 (comment) I think the second image should be left as is, sorry again. The first one could be turned into a @check_figures_equal between calling ax.acorr and manually calling np.correlate and generating the corresponding plot using ax.vlines/ax.hline (which is what ax.acorr uses internally).

updated the tests as suggested (restored the images and image_interps.py, replaced image comparison for ax.acorr with @check_figures_equal).

@pharshalp pharshalp changed the title TST: Removed text from test images TST: test_acorr (replaced image comparison with figure comparion) Feb 4, 2020
anntzer
anntzer approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@timhoffm timhoffm merged commit 53c8d6a into matplotlib:master Feb 8, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone Feb 13, 2020
@QuLogic QuLogic changed the title TST: test_acorr (replaced image comparison with figure comparion) TST: test_acorr (replaced image comparison with figure comparison) Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pharshalp @anntzer @timhoffm @QuLogic
0