8000 Make Text.update_from copy usetex state. by anntzer · Pull Request #16359 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Make Text.update_from copy usetex state. #16359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

Make Text.update_from copy usetex state. #16359

merged 1 commit into from
Jan 29, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 28, 2020

This is used in particular by tick handling code to propagate text
properties across ticks, so this change avoids having some ticks using
usetex and others not using usetex if the rcParam value changes after
axes creation.

As an example, see the "-1" tick on the left of #6323 (comment) which is the only one not using usetex, even though the entire left axes should not be using usetex.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Make Text.update_from copy usetex state.
6c76bbd 
This is used in particular by tick handling code to propagate text
properties across ticks, so this change avoids having some ticks using
usetex and others not using usetex if the rcParam value changes after
axes creation.
@anntzer anntzer added this to the v3.3.0 milestone Jan 28, 2020
timhoffm
timhoffm approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that this was the only missing attribute in copy_from?

@anntzer
Copy link
Contributor Author
anntzer commented Jan 28, 2020

No, but it's at least one that really has an observable effect.

tacaswell
tacaswell approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge on CI green.

@tacaswell tacaswell merged commit 9158276 into matplotlib:master Jan 29, 2020
@anntzer anntzer deleted the copy-usetex branch January 29, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: text/usetex
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm
0