Backport PR #16255 on branch v2.2.x (Move version info to sidebar) #16352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@timhoffm I think you have to rebase this branch for circle to pick up the change. |
|
Yes, I was busy yesterday. Will do tonight. If you need itvearlier, feel free to rebase and push to this branch. |
bb00de9 to
45d09ac
Compare
45d09ac to
7ec1740
Compare
|
Builds cleanly locally, will merge as soon as CI passes. |
tacaswell
approved these changes
Feb 1, 2020
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Backport PR #16255 on branch v2.2.x (Move version info to sidebar).
Need to check that styling is correct via the CI built version of the docs.
I couldn't easily build 2.2.x docs locally probably because my dev env is not compatible to 2.2 anymore.