8000 TST: Improved test (getting rid of image comparison test for test_titletwiny) by pharshalp · Pull Request #16350 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

TST: Improved test (getting rid of image comparison test for test_titletwiny) #16350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2020
Merged

TST: Improved test (getting rid of image comparison test for test_titletwiny) #16350

merged 1 commit into from
Jan 29, 2020

Conversation

pharshalp
Copy link
Contributor
@pharshalp pharshalp commented Jan 27, 2020 •
edited
Loading

PR Summary

attempting to address the second bullet in #15054 🤞
(getting rid of image comparison test for test_titletwiny)

will create separate PRs for the other two tests.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer
anntzer reviewed Jan 27, 2020
View reviewed changes
anntzer
anntzer reviewed Jan 27, 2020
View reviewed changes
@anntzer
Copy link
Contributor
anntzer commented Jan 27, 2020

Just a few nits, but otherwise lgtm, thanks for tacking this :)

@pharshalp
Copy link
Contributor Author
pharshalp commented Jan 27, 2020 •
edited
Loading

interestingly the test passes when I run it on its own... need to take a closer look at my approach. may be I am missing something very fundamental... came up with a compromise. hopefully it is good enough :)

@pharshalp pharshalp changed the title ENH: Improved test (getting rid of image comparison test for test_titletwiny) TST: Improved test (getting rid of image comparison test for test_titletwiny) Jan 28, 2020
timhoffm
timhoffm reviewed Jan 28, 2020
View reviewed changes
timhoffm
timhoffm approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on CI pass

jklymak
jklymak reviewed Jan 28, 2020
View reviewed changes
@anntzer anntzer merged commit 7f60002 into matplotlib:master Jan 29, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@timhoffm timhoffm timhoffm approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pharshalp @anntzer @jklymak @timhoffm @QuLogic
0