Remove unnecessary Legend._approx_text_height. #16312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only ever called with renderer=None, returning the fontsize directly. In fact the rest of the code assumes that the font size is in points (inch/72), not in pixels. This can be checked by setting the dpi to a large value (e.g. 500), forcing the renderer to be not None by adding `renderer = self.figure.canvas._cachedRenderer` and making sure that a cached renderer exists (via `fig.canvas.draw()`) before creating the legend -- such a patch results in a highly distorted legend layout, whereas just using fontsize is fine even at high dpi.
timhoffm
approved these changes
Jan 24, 2020
jklymak
approved these changes
Jan 24, 2020
|
good to go? |
|
I would have expected this change to cause image test failures, or is the |
|
It is never hit, as explained above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only ever called with renderer=None, returning the fontsize
directly. In fact the rest of the code assumes that the font size is
in points (inch/72), not in pixels. This can be checked by setting the
dpi to a large value (e.g. 500), forcing the renderer to be not None by
adding
renderer = self.figure.canvas._cachedRendererand making surethat a cached renderer exists (via
fig.canvas.draw()) before creatingthe legend -- such a patch results in a highly distorted legend layout,
whereas just using fontsize is fine even at high dpi.
PR Summary
PR Checklist