Fix spy(..., marker=<not-None>, origin="lower") #16265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
and validate the origin kwarg both for spy() and for imshow().
There are some other slightly questionable choices in spy() (e.g. always
calling `xaxis.set_ticks_position("both")` but not doing the same for
the yaxis), but let's leave this as is for now.
anntzer
commented
Jan 19, 2020
| @@ -7560,6 +7555,11 @@ def spy(self, Z, precision=0, marker=None, markersize=None, | |||
| non-square pixels. | |||
| - *None*: Use :rc:`image.aspect`. | |||
|
|
|||
| origin : {'upper', 'lower'}, default: :rc:`image.origin` | |||
There was a problem hiding this comment.
this just makes the doc order match the signature order.
tacaswell
reviewed
Jan 19, 2020
| self.title.set_y(1.05) | ||
| self.xaxis.tick_top() | ||
| if origin == "upper": |
There was a problem hiding this comment.
This seems like an additional change in behavior?
There was a problem hiding this comment.
that was explicitly mentioned in the report ("Though it's worth pointing out that the x-axis ticks and labels always end up in upper spine, not the lower one, regardless of origin='upper' or origin='lower'. The behavior of imshow is a bit different. If origin='lower', the ticks and labels are moved to the bottom.") and clearly looks like an error as well.
tacaswell
approved these changes
Jan 19, 2020
timhoffm
approved these changes
Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and validate the origin kwarg both for spy() and for imshow().
There are some other slightly questionable choices in spy() (e.g. always
calling
xaxis.set_ticks_position("both")but not doing the same forthe yaxis), but let's leave this as is for now.
Closes #16252.
PR Summary
PR Checklist