8000 FIX: AttributeError in TimerBase.start by samschott · Pull Request #16235 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: AttributeError in TimerBase.start #16235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

FIX: AttributeError in TimerBase.start #16235

merged 1 commit into from
Jan 15, 2020

Conversation

samschott
Copy link

PR Summary

When calling TimerBase.start with a new interval, an AttributeError is raised because TimerBase has no method _set_interval.

Don't call TimerBase._set_interval (does not exist) but set the property TimerBase .interval instead.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

FIX: AttributeError in TimerBase.start ...
84cf02f 
... when calling with new interval
anntzer
anntzer approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I missed that in #11698.
Milestoned as 3.2, but could even be backported to 3.1.

@anntzer anntzer added this to the v3.2.0 milestone Jan 15, 2020
@tacaswell tacaswell modified the milestones: v3.2.0, v3.1.3 Jan 15, 2020
@tacaswell tacaswell merged commit c2cfdf3 into matplotlib:master Jan 15, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 15, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#16235: FIX: AttributeError in TimerBase.start
f32f433
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 15, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 15, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#16235: FIX: AttributeError in TimerBase.start
3525fe1
@tacaswell
Copy link
Member

Thanks for the fix @samschott ! The OSX test had timed out while failing to get hardware.

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 15, 2020
Merged
@samschott
Copy link
Author

Wow, you all have a quick response time! Thanks for merging.

Kojoley added a commit that referenced this pull request Jan 16, 2020
@Kojoley
Merge pull request #16237 from meeseeksmachine/auto-backport-of-pr-16…
d10aacf 
…235-on-v3.1.x

Backport PR #16235 on branch v3.1.x (FIX: AttributeError in TimerBase.start)
Kojoley added a commit that referenced this pull request Jan 16, 2020
@Kojoley
Merge pull request #16238 from meeseeksmachine/auto-backport-of-pr-16…
2bf95db 
…235-on-v3.2.x

Backport PR #16235 on branch v3.2.x (FIX: AttributeError in TimerBase.start)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@samschott @tacaswell @anntzer @timhoffm
0