8000 Fix trivial typo in deprecation warning message. by anntzer · Pull Request #16164 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix trivial typo in deprecation warning message. #16164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix trivial typo in deprecation warning message. #16164

merged 1 commit into from
Jan 8, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 8, 2020

PR Summary

fixup for #15894.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 8, 2020
@anntzer anntzer added this to the v3.3.0 milestone Jan 8, 2020
@story645
Copy link
Member
story645 commented Jan 8, 2020

I'm a bit confused on how this is release critical but tagged for 3.3?

@jklymak
Copy link
Member
jklymak commented Jan 8, 2020

Some of his PRs get lost?

@jklymak jklymak merged commit 22f4782 into matplotlib:master Jan 8, 2020
@anntzer anntzer deleted the deptypo branch January 8, 2020 17:20
@anntzer
Copy link
Contributor Author
anntzer commented Jan 8, 2020

yup, just making sure it doesn't fall between the cracks

@astromancer
Copy link
Contributor

I personally found this deprecation message a little unclear. It wasn't obvious to me upon first reading it that the deprecation is specifically for lists of strings and not for the latex preamble parameter as a whole. Might be good to explicitly include the words "list of strings" in the deprecation message instead of (or in addition to) printing the actual user input list.

@anntzer anntzer mentioned this pull request May 13, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @story645 @jklymak @astromancer
0