8000 CI: Do not use nbformat 5.0.0/5.0.1 for testing by Kojoley · Pull Request #16128 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

CI: Do not use nbformat 5.0.0/5.0.1 for testing #16128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

CI: Do not use nbformat 5.0.0/5.0.1 for testing #16128

merged 1 commit into from
Jan 7, 2020

Conversation

Kojoley
Copy link
Member
@Kojoley Kojoley commented Jan 6, 2020

PR Summary

Closes #16127

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@Kojoley Kojoley added this to the v3.2.0 milestone Jan 6, 2020
anntzer
anntzer requested changes Jan 6, 2020
View reviewed changes
@Kojoley Kojoley force-pushed the ci-nbconvert-5.0.0-missing-schema-files branch from 326262e to d975f58 Compare January 6, 2020 22:23
@Kojoley Kojoley changed the title CI: Do not use nbconvert 5.0.0 for testing CI: Do not use nbformat 5.0.0 for testing Jan 6, 2020
anntzer
anntzer approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-ci

@Kojoley
Copy link
Member Author

It looks like we have to blacklist 5.0.1 too

@Kojoley Kojoley force-pushed the ci-nbconvert-5.0.0-missing-schema-files branch from d975f58 to cc5e671 Compare January 6, 2020 23:10
@Kojoley Kojoley changed the title CI: Do not use nbformat 5.0.0 for testing CI: Do not use nbformat 5.0.0/5.0.1 for testing Jan 6, 2020
@Kojoley
Copy link
Member Author
Kojoley commented Jan 6, 2020

5.0.2 fixed the issue, so I am not sure whether this PR should be merged or closed.

@anntzer
Copy link
Contributor
anntzer commented Jan 7, 2020

Let's keep it for now, it's not too onerous...

@tacaswell tacaswell merged commit 2fff6d7 into matplotlib:master Jan 7, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 7, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#16128: CI: Do not use nbformat 5.0.0/5.0.1 for…
3c8d95f 
… testing
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 7, 2020
Merged
@Kojoley Kojoley deleted the ci-nbconvert-5.0.0-missing-schema-files branch January 7, 2020 21:23
Kojoley added a commit that referenced this pull request Jan 8, 2020
@Kojoley
Merge pull request #16148 from meeseeksmachine/auto-backport-of-pr-16…
3138397 
…128-on-v3.2.x

Backport PR #16128 on branch v3.2.x (CI: Do not use nbformat 5.0.0/5.0.1 for testing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

nbformat 5.0.0 missing schema files
3 participants
@Kojoley @anntzer @tacaswell
0