8000 FIX: use supported attribute to check pillow version by tacaswell · Pull Request #16086 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: use supported attribute to check pillow version #16086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

FIX: use supported attribute to check pillow version #16086

merged 1 commit into from
Jan 4, 2020

Conversation

tacaswell
Copy link
Member

the PILLOW_VERSION attribute was deprecated in pillow 5.2 and removed
in pillow 7.0. The version attribute is present in the minimum
version we check (3.4).

closes #16083

@tacaswell
FIX: use supported attribute to check pillow version
3369e3b 
the PILLOW_VERSION attribute was deprecated in pillow 5.2 and removed
in pillow 7.0.  The __version__ attribute is present in the minimum
version we check (3.4).

closes matplotlib#16083
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 4, 2020
@tacaswell tacaswell added this to the v3.2.0 milestone Jan 4, 2020
@tacaswell
Copy link
Member Author

This will have to be backported to v3.1.x and v2.2.x

@timhoffm timhoffm merged commit 9bb8e6c into matplotlib:v3.2.x Jan 4, 2020
@anntzer anntzer mentioned this pull request Jan 4, 2020
Closed
@timhoffm
Copy link
Member
timhoffm commented Jan 4, 2020

@meeseeksdev backport to v3.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 4, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 4, 2020
@timhoffm @meeseeksmachine
Backport PR matplotlib#16086: FIX: use supported attribute to check p…
5f61067 
…illow version
@timhoffm
Copy link
Member
timhoffm commented Jan 4, 2020

v2.2.x does not have the version check and thus does not need a backport.

timhoffm added a commit that referenced this pull request Jan 4, 2020
@timhoffm
Merge pull request #16091 from meeseeksmachine/auto-backport-of-pr-16…
388af15 
…086-on-v3.1.x

Backport PR #16086 on branch v3.1.x (FIX: use supported attribute to check pillow version)
@tacaswell tacaswell deleted the fix_pil_versioncheck branch January 6, 2020 13:51
@tacaswell
Copy link
Member Author

Thanks for taking care of the backports @timhoffm !

@hugovk hugovk mentioned this pull request Jan 17, 2020
Closed
@hugovk
Copy link
Contributor
hugovk commented Jan 17, 2020

Is there a rough schedule for the next release (eg. 3.1.x or 3.2.0) with this fix? Thanks!

@tacaswell
Copy link
Member Author

I am working on it right now, goal is 2.2.5, 3.1.3, and 3.2.0rc3 by end of day tomorrow 🤞 .

@tacaswell
Copy link
Member Author

Ended up going down a few extra rabbits holes (and having to fix a pandas related bug) and took almost 2 more weeks, but I just tagged 3.1.3, should make it's way out through the binary channels in the next few days.

Sorry this took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @timhoffm @hugovk @jklymak
0