8000 Rely on pytest to record warnings, rather than doing it manually. by anntzer · Pull Request #16036 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Rely on pytest to record warnings, rather than doing it manually. #16036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2019
Merged

Rely on pytest to record warnings, rather than doing it manually. #16036

merged 1 commit into from
Dec 30, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 29, 2019

Technically we could even get rid of the assert len(recwarn) == 0
lines because we fail the tests on any warning, but I left them there
for explicitness.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Rely on pytest to record warnings, rather than doing it manually.
2ad47ca 
Technically we could even get rid of the `assert len(recwarn) == 0`
lines because we fail the tests on any warning, but I left them there
for explicitness.
@dstansby dstansby added this to the v3.3.0 milestone Dec 30, 2019
@dstansby dstansby merged commit 11a5c9f into matplotlib:master Dec 30, 2019
@anntzer anntzer deleted the recwarn branch December 30, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @dstansby
0