8000 Make eventplot use the standard alias resolution mechanism. by anntzer · Pull Request #16035 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Make eventplot use the standard alias resolution mechanism. #16035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2019
Merged

Make eventplot use the standard alias resolution mechanism. #16035

merged 1 commit into from
Dec 30, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 29, 2019

... or rather, prepare its move.

Right now eventplot is the sole user of local_over_kwdict for alias
resolution. Prepare to move it towards cbook.normalize_kwargs instead.

normalize_kwargs is stricter (it raises on conflicting kwargs), so we
need a deprecation period for conficting kwargs as well.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer 8000 anntzer added the Maintenance label Dec 29, 2019
@anntzer
Make eventplot use the standard alias resolution mechanism.
dbc4295 
... or rather, prepare its move.

Right now eventplot is the sole user of local_over_kwdict for alias
resolution.  Prepare to move it towards cbook.normalize_kwargs instead.

normalize_kwargs is stricter (it raises on conflicting kwargs), so we
need a deprecation period for conficting kwargs as well.
@jklymak jklymak merged commit 5829e30 into matplotlib:master Dec 30, 2019
@anntzer anntzer deleted the local_over_kwdict branch December 30, 2019 20:14
@QuLogic QuLogic added this to the v3.3.0 milestone Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @QuLogic @jklymak
0