8000 Relayout some conditions in axes_grid. by anntzer · Pull Request #16013 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Relayout some conditions in axes_grid. #16013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2019
Merged

Relayout some conditions in axes_grid. #16013

merged 1 commit into from
Dec 27, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 23, 2019 
if ((self._colorbar_mode == "each" or
        (self._colorbar_mode == 'edge' and
            col == self._ncols - 1)) and
        self._colorbar_location == "right"):

has newlines in somewhat confusing places.

if (cb_location == "right"
        and (cb_mode == "each"
             or (cb_mode == "edge" and col == self._ncols - 1))):

is hopefully more legible.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Relayout some conditions in axes_grid.
f583d05 
```
if ((self._colorbar_mode == "each" or
        (self._colorbar_mode == 'edge' and
            col == self._ncols - 1)) and
        self._colorbar_location == "right"):
```
has newlines in somewhat confusing places.
```
if (cb_location == "right"
        and (cb_mode == "each"
             or (cb_mode == "edge" and col == self._ncols - 1))):
```
is hopefully more legible.
@anntzer anntzer force-pushed the axes_grid_update_locators branch from c4baf0d to f583d05 Compare December 25, 2019 20:00
@timhoffm timhoffm added this to the v3.3.0 milestone Dec 27, 2019
@timhoffm timhoffm merged commit bf74a40 into matplotlib:master Dec 27, 2019
@anntzer anntzer deleted the axes_grid_update_locators branch December 27, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0