8000 Remove unused imports by timhoffm · Pull Request #16008 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove unused imports #16008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2019
Merged

Remove unused imports #16008

merged 1 commit into from
Dec 30, 2019

Conversation

timhoffm
Copy link
Member

No description provided.

@timhoffm timhoffm added this to the v3.3.0 milestone Dec 22, 2019
@dopplershift
Copy link
Contributor

Can you update .flake8 to remove the F401 ignore for these files? That way they stay cleaned up going forward.

@timhoffm
Copy link
Member Author

Updated .flake8 for all changes but backend_*.py: F401. This also covers intended unused imports in some backends.

@dopplershift
Copy link
Contributor

Which of course reveals that there are further unused imports in those files. Any interest in cleaning those up too?

@timhoffm
Copy link
Member Author

Will look at these some time later. Some of them contain FigureManager* and NavigationToolbar* imports from other backends, which may actually be intended to be imported in the backend to make them available to users. But this needs clarification. Also I'd do a full search for unused F401 across the lib. But let's defer these things to a future PR.

anntzer
anntzer approved these changes Dec 29, 2019
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postci

@dopplershift dopplershift merged commit 8d06cbc into matplotlib:master Dec 30, 2019
@timhoffm timhoffm deleted the unused-imports branch December 30, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @dopplershift @anntzer
0