Ignore pos in StrCategoryFormatter.__call__ to display correct label in the preview window #16006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
requested changes
Dec 23, 2019
| assert ax.yaxis.major.formatter(i+1, i+1) == "" | ||
| assert ax.yaxis.major.formatter(0, None) == "" | ||
| assert ax.yaxis.major.formatter(i) == d | ||
| assert ax.yaxis.major.formatter(i+1) == "" |
There was a problem hiding this comment.
Could you add a test that ax.yaxis.major.formatter(i, None) gives d as the label? (which it wouldn't do before this fix)
There was a problem hiding this comment.
Thanks, I have updated the test.
dstansby
approved these changes
Dec 29, 2019
anntzer
approved these changes
Jan 2, 2020
|
Thanks :) |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Feb 16, 2020
…ll__ to display correct label in the preview window Ignore pos in StrCategoryFormatter.__call__ to display correct… (matplotlib#16006) Ignore pos in StrCategoryFormatter.__call__ to display correct label in the preview window Conflicts: lib/matplotlib/tests/test_category.py - collision with py2 removal work (_to_str)
6 tasks
dstansby
added a commit
that referenced
this pull request
Feb 17, 2020
…-v3.2.x Backport PR #16006: Ignore pos in StrCategoryFormatter.__call__ to di…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14881
The position pos in
__call__can be ignored as the tick label is independent of position. So,__call__(value, None)would return a category label even if pos isNone, which is the expected behavior.The test case has been modified to pass only a single argument (so pos defaults to
None).