10000 Some unicode-support related cleanups. by anntzer · Pull Request #15940 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Some unicode-support related cleanups. #15940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2019
Merged

Some unicode-support related cleanups. #15940

merged 1 commit into from
Dec 29, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 15, 2019
  • TeX demo: the old text is pretty outdated -- all backends support
    usetex, and the output of the TeX process is now hidden.
  • _layoutbox.py: we don't support Py2 anymore.
  • polar.py: the inherited docstring is enough.
  • test_animation.py: these refer to very old bugs, likely fixed by
    now.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Dec 15, 2019
View reviewed changes
timhoffm
timhoffm approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe improve wording.

@anntzer
Some unicode-support related cleanups.
1cb198e 
- TeX demo: the old text is pretty outdated -- all backends support
  usetex, and the output of the TeX process is now hidden.
- _layoutbox.py: we don't support Py2 anymore.
- polar.py: the inherited docstring is enough.
- test_animation.py: these refer to very old bugs, likely fixed by
  now.
@timhoffm timhoffm added this to the v3.3.0 milestone Dec 15, 2019
8F84
@dstansby dstansby merged commit d3603bf into matplotlib:master Dec 29, 2019
@anntzer anntzer deleted the unicode branch December 29, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @dstansby
0