8000 Deprecate case-insensitive capstyles and joinstyles. by anntzer · Pull Request #15876 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate case-insensitive capstyles and joinstyles. #15876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2019
Merged

Deprecate case-insensitive capstyles and joinstyles. #15876

merged 1 commit into from
Dec 8, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 8, 2019

Collections have never accepted case-sensitive capstyles/joinstyles
(their setter don't do s.lower() first) but AFAIK no one has
complained about it, which suggests their use is rare.

There isn't much of a reason in supporting them, case-insensitive APIs
are not-so pythonic, and unsupporting them makes code map more easily to
cbook._check_in_list.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Dec 8, 2019
@anntzer
Deprecate case-insensitive capstyles and joinstyles.
5a9ea37 
Collections have never accepted case-sensitive capstyles/joinstyles
(their setter don't do `s.lower()` first) but AFAIK no one has
complained about it, which suggests their use is rare.

There isn't much of a reason in supporting them, case-insensitive APIs
are not-so pythonic, and unsupporting them makes code map more easily to
cbook._check_in_list.
@anntzer anntzer force-pushed the case-sensitive-capjoinstyles branch from d9ec9f0 to 5a9ea37 Compare December 8, 2019 16:07
@tacaswell tacaswell merged commit b8eb4b2 into matplotlib:master Dec 8, 2019
@anntzer anntzer deleted the case-sensitive-capjoinstyles branch December 8, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell
0